Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21703#discussion_r200005737
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
 ---
    @@ -179,6 +179,12 @@ object TypeCoercion {
           .orElse((t1, t2) match {
             case (ArrayType(et1, containsNull1), ArrayType(et2, 
containsNull2)) =>
               findWiderTypeForTwo(et1, et2).map(ArrayType(_, containsNull1 || 
containsNull2))
    +        case (MapType(kt1, vt1, valueContainsNull1), MapType(kt2, vt2, 
valueContainsNull2)) =>
    --- End diff --
    
    not related to this PR, but shall we also handle struct type here?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to