Github user rdblue commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21556#discussion_r201754882
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala
 ---
    @@ -225,12 +316,44 @@ private[parquet] class ParquetFilters(pushDownDate: 
Boolean, pushDownStartWith:
       def createFilter(schema: MessageType, predicate: sources.Filter): 
Option[FilterPredicate] = {
         val nameToType = getFieldMap(schema)
     
    +    def isDecimalMatched(value: Any, decimalMeta: DecimalMetadata): 
Boolean = value match {
    +      case decimal: JBigDecimal =>
    +        decimal.scale == decimalMeta.getScale
    +      case _ => false
    +    }
    +
    +    // Since SPARK-24716, ParquetFilter accepts parquet file schema to 
convert to
    --- End diff --
    
    Is this issue reference correct? The PR says this is for SPARK-24549.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to