GitHub user NiharS opened a pull request:
https://github.com/apache/spark/pull/21765
[MINOR][CORE] Add test cases for RDD.cartesian
## What changes were proposed in this pull request?
While looking through the codebase, it appeared that the scala code for
RDD.cartesian does not have any tests for correctness. This adds a couple basic
tests to verify cartesian yields correct values. While the implementation for
RDD.cartesian is pretty simple, it always helps to have a few tests!
## How was this patch tested?
The new test cases pass, and the scala style tests from running
dev/run-tests all pass.
Please review http://spark.apache.org/contributing.html before opening a
pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/NiharS/spark cartesianTests
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/21765.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #21765
----
commit 9df4c3b4a71082181aa979c3bddf2c3d99db256e
Author: Nihar Sheth <niharrsheth@...>
Date: 2018-07-13T20:37:59Z
[MINOR][CORE] Add test cases for RDD.cartesian
The scala code for RDD.cartesian does not have any tests for correctness.
This adds a couple basic tests to verify cartesian yields correct values.
Passes the added test cases, and passes the scala style tests.
Author: Nihar Sheth <niharrsh...@gmail.com>
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
