Github user huaxingao commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21710#discussion_r203526021
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/ml/r/PrefixSpanWrapper.scala ---
    @@ -0,0 +1,34 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.ml.r
    +
    +import org.apache.spark.ml.fpm.PrefixSpan
    +
    +private[r] object PrefixSpanWrapper {
    +  def getPrefixSpan(
    +      minSupport: Double,
    +      maxPatternLength: Int,
    +      maxLocalProjDBSize: Double,
    --- End diff --
    
    ```maxLocalProjDBSize``` is a ```LongParam``` in scala, but it seems that r 
doesn't have ```long```. 
    See ```help(integer):```
    ```
     Note that on almost all implementations of R the range of
     representable integers is restricted to about +/-2*10^9: ‘double’s
     can hold much larger integers exactly.
    ```
    so I used ```double``` in r, and do ```toLong``` later


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to