Github user jiangxb1987 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21758#discussion_r203741697
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/WorkerOffer.scala 
---
    @@ -21,4 +21,10 @@ package org.apache.spark.scheduler
      * Represents free resources available on an executor.
      */
     private[spark]
    -case class WorkerOffer(executorId: String, host: String, cores: Int)
    +case class WorkerOffer(
    +    executorId: String,
    +    host: String,
    +    cores: Int,
    +    // `address` is an optional hostPort string, it provide more useful 
information than `host`
    +    // when multiple executors are launched on the same host.
    +    address: Option[String] = None)
    --- End diff --
    
    This follows what `ExecutorData` does, having both `executorAddress` and 
`executorHost`, IIUC the host of `executorAddress` doesn't necessarily have to 
be the same as `executorHost`.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to