Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/21822#discussion_r203924609
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -533,7 +537,8 @@ trait CheckAnalysis extends PredicateHelper {
// Simplify the predicates before validating any unsupported
correlation patterns
// in the plan.
- BooleanSimplification(sub).foreachUp {
+ // TODO(rxin): Why did this need to call BooleanSimplification???
--- End diff --
@rxin From what i remember Reynold, most of this logic was housed in
Analyzer before and we moved it to optimizer. In the old code we used to walk
the plan after simplifying the predicates. The comment used to read "Simplify
the predicates before pulling them out.". I just retained that semantics.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
