Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21815#discussion_r203976429
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/FileSourceScanExecSuite.scala
---
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution
+
+import org.apache.spark.sql.test.SharedSQLContext
+
+class FileSourceScanExecSuite extends SharedSQLContext {
+ test("FileSourceScanExec should be canonicalizable on executor side") {
--- End diff --
There's few things bothering for that actually - it's kind of messy to
create `FileSourceScanExec` without `SparkSession` (and also without other
utils from `SharedSQLContext`), and `QueryPlanSuite` is under `catalyst`
whereas this plan itself is under `execution` in SQL core.
And, I actually believe this PR more targets to make the plan
canonicalizable after it's de/serialized since this plan itself is serializable
and deserializable already but it's not canonicalizable after that.
Let me try to clean up based on your comment anyway.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
