Github user woodthom2 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21828#discussion_r203997163
--- Diff: python/pyspark/ml/regression.py ---
@@ -1116,7 +1116,7 @@ def setParams(self, featuresCol="features",
labelCol="label", predictionCol="pre
maxDepth=5, maxBins=32, minInstancesPerNode=1,
minInfoGain=0.0,
maxMemoryInMB=256, cacheNodeIds=False,
subsamplingRate=1.0,
checkpointInterval=10, lossType="squared", maxIter=20,
stepSize=0.1, seed=None,
- impuriy="variance", featureSubsetStrategy="all"):
+ impurity="variance", featureSubsetStrategy="all"):
--- End diff --
what about this until next major release?
```
def setParams(self, featuresCol="features", labelCol="label",
predictionCol="prediction",
maxDepth=5, maxBins=32, minInstancesPerNode=1,
minInfoGain=0.0,
maxMemoryInMB=256, cacheNodeIds=False,
subsamplingRate=1.0,
checkpointInterval=10, lossType="squared", maxIter=20,
stepSize=0.1, seed=None,
impuriy=None, impurity="variance",
featureSubsetStrategy="all"):
if impuriy is not None: # for backward compatibility
impurity = impuriy
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
