Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21826#discussion_r204190916
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -442,8 +442,6 @@ case class Or(left: Expression, right: Expression)
extends BinaryOperator with P
override def inputType: AbstractDataType = BooleanType
- override def symbol: String = "||"
--- End diff --
I think this won't be compiled?
```
class Or needs to be abstract, since method symbol in class BinaryOperator
of type => String is not defined
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
