Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21758#discussion_r204315409
--- Diff: core/src/main/scala/org/apache/spark/rdd/ShuffledRDD.scala ---
@@ -110,4 +110,6 @@ class ShuffledRDD[K: ClassTag, V: ClassTag, C:
ClassTag](
super.clearDependencies()
prev = null
}
+
+ @transient protected lazy override val isBarrier_ : Boolean = false
--- End diff --
nit: can't we here override `def isBarrier` to return `false` in order to
avoid the unneeded synchronization introduced by lazy?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
