Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/21835#discussion_r205000041
--- Diff: R/pkg/tests/fulltests/test_context.R ---
@@ -21,10 +21,11 @@ test_that("Check masked functions", {
# Check that we are not masking any new function from base, stats,
testthat unexpectedly
# NOTE: We should avoid adding entries to *namesOfMaskedCompletely* as
masked functions make it
# hard for users to use base R functions. Please check when in doubt.
- namesOfMaskedCompletely <- c("cov", "filter", "sample", "not")
+ namesOfMaskedCompletely <- c("cov", "filter", "sample", "not",
"sequence")
--- End diff --
thanks, this is a bit tricky because of the way tests work, could you do
one check - install the package locally (`R CMD INSTALL --library=lib pkg/`)
and then load the package from lib, in R, `library(SparkR,
lib.loc='pathto/lib')`
then try calling base::sequence and SparkR::sequence
also, please add a test for base::sequence too - we have that for other
functions
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
