Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21871#discussion_r205068186
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/typeCoercion/native/inConversion.sql
---
@@ -328,3 +328,159 @@ SELECT cast('2017-12-12 09:30:00' as date) in
(cast('2017-12-12 09:30:00' as dat
SELECT cast('2017-12-12 09:30:00' as date) in (cast('2017-12-12 09:30:00'
as date), cast(1 as boolean)) FROM t;
SELECT cast('2017-12-12 09:30:00' as date) in (cast('2017-12-12 09:30:00'
as date), cast('2017-12-11 09:30:00.0' as timestamp)) FROM t;
SELECT cast('2017-12-12 09:30:00' as date) in (cast('2017-12-12 09:30:00'
as date), cast('2017-12-11 09:30:00' as date)) FROM t;
+
+SELECT * FROM t WHERE (cast(1 as tinyint)) IN (SELECT cast(1 as tinyint)
FROM t);
--- End diff --
Do we really need to test all the combinations? We need most of such logics
should be tested in `findWiderTypeWithoutStringPromotionForTwo` and we could
have just few end to end tests.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
