Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/spark/pull/21875#discussion_r205267327
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala
---
@@ -183,6 +183,9 @@ class JDBCOptions(
}
// An option to execute custom SQL before fetching data from the remote
DB
val sessionInitStatement = parameters.get(JDBC_SESSION_INIT_STATEMENT)
+
+ // An option to allow/disallow pushing down predicate into JDBC data
source
+ val pushDownPredicate = parameters.getOrElse(JDBC_PUSHDOWN_PREDICATE,
"true").toBoolean
--- End diff --
Or one could argue that "predicate" is a notion of all filters as a whole.
It's a nice reminder though. I had not thought about it, but anyway I just
checked: we use `PushDownPredicate` and the singular form in similar rules. So
maybe we keep it singular here too?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
