Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21320
> After more than two years of off and on review, discussion/debate,
nitpicking, commits, steps forward and backwards, to have someone swoop in at
this time with a new raft of nitpicking and stylistic issues that set the
review back again further is beyond maddening.
I think that's primarily because the change looks incomplete but the
feature itself sounds good to have. I think that's why people try to take a
look a lot.
Stepping forward and backwards is bad. That's why I am sticking with this
PR to get this change in and help you address other people's comments and
prevent such forward and backward.
Stylistic issues are virtually based upon
https://github.com/databricks/scala-style-guide .
Nitpicking from me is basically from referring other codes or PRs in Spark,
or other committer's preference so that we can get through this. I guess nits
are still good to fix if you happen to push more changes. I guess it would take
few seconds to address them. If that's not, please ignore my nit or minor
comments. They don't block the PR usually.
For clarification, few comments mentioned in
https://github.com/apache/spark/pull/21320#issuecomment-407714036 are pretty
reject comments in general in other PRs too.
> Contributing to this PR is a tax on what is completely voluntary, unpaid
time.
FWIW, all my works have been unpaid and completely voluntary to me more
than 3 years in the past except the recent half 6 months (which basically means
until I became a committer). To be honest, I believe I still work on Spark like
when I worked individually before.
> I have no professional responsibility to this effort. Maybe it's better
off done by someone who does.
I completely agree. There should be no professional responsibility like a
task to do in an open source in general. I think no one has that professional
responsibility to take this and here we should be transparent on this. If
anyone interested in this finds that you want someone else to take over, this
might be taken over _voluntarily_ with a comment saying I want to take over
this.
I might cc some people who might be interested in this in order to inform
them but it doesn't mean I hand it off to someone else.
I am sorry if you felt I am pushing or rushing you - was trying to get this
change in since people find it's a good feature to have. That's why I
prioritized this and stick to this PR.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
