Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21852#discussion_r206000777
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
 ---
    @@ -416,6 +416,23 @@ object SimplifyConditionals extends Rule[LogicalPlan] 
with PredicateHelper {
             // these branches can be pruned away
             val (h, t) = branches.span(_._1 != TrueLiteral)
             CaseWhen( h :+ t.head, None)
    +
    +      case e @ CaseWhen(branches, Some(elseValue)) if {
    +        val values = branches.map(_._2) :+ elseValue
    +        values.tail.forall(values.head.semanticEquals)
    --- End diff --
    
    I think the case is: remove branches that have the same value of `else`:
    ```
    branches.exists(_._2.semanticEquals(elseValue))
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to