Github user mccheah commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21221#discussion_r206333086
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala ---
    @@ -93,6 +95,9 @@ private[spark] class EventLoggingListener(
       // Visible for tests only.
       private[scheduler] val logPath = getLogPath(logBaseDir, appId, 
appAttemptId, compressionCodecName)
     
    +  // map of (stageId, stageAttempt), to peak executor metrics for the stage
    +  private val liveStageExecutorMetrics = HashMap[(Int, Int), 
HashMap[String, ExecutorMetrics]]()
    --- End diff --
    
    Do these have to be `HashMap`s or can they be just `m,utable.Map`s? Can 
instantiate with `mutable.Map.empty[..., ...]()`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to