Github user jerryshao commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21895#discussion_r206725814
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
    @@ -973,6 +978,42 @@ private[history] object FsHistoryProvider {
       private[history] val CURRENT_LISTING_VERSION = 1L
     }
     
    +private[history] trait CachedFileSystemHelper extends Logging {
    --- End diff --
    
    As discussed offline, my main concern is about cache inconsistency if user 
changed the file permission during cache valid time.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to