GitHub user cloud-fan opened a pull request:

    https://github.com/apache/spark/pull/21958

    [minor] remove dead code in ExpressionEvalHelper

    ## What changes were proposed in this pull request?
    
    This addresses https://github.com/apache/spark/pull/21236/files#r207078480
    
    both https://github.com/apache/spark/pull/21236 and 
https://github.com/apache/spark/pull/21838 add a InternalRow result check to 
ExpressionEvalHelper and becomes duplicated.
    
    ## How was this patch tested?
    
    N/A

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloud-fan/spark minor

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/21958.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #21958
    
----
commit 19dd61431326a5a01c6b8f63dc71a4663a9bb590
Author: Wenchen Fan <wenchen@...>
Date:   2018-08-02T04:43:31Z

    remove dead code in ExpressionEvalHelper

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to