Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21935#discussion_r207100964
  
    --- Diff: 
external/avro/src/main/scala/org/apache/spark/sql/avro/AvroDeserializer.scala 
---
    @@ -86,8 +87,16 @@ class AvroDeserializer(rootAvroType: Schema, 
rootCatalystType: DataType) {
           case (LONG, LongType) => (updater, ordinal, value) =>
             updater.setLong(ordinal, value.asInstanceOf[Long])
     
    -      case (LONG, TimestampType) => (updater, ordinal, value) =>
    -        updater.setLong(ordinal, value.asInstanceOf[Long] * 1000)
    +      case (LONG, TimestampType) => avroType.getLogicalType match {
    +        case _: TimestampMillis => (updater, ordinal, value) =>
    +          updater.setLong(ordinal, value.asInstanceOf[Long] * 1000)
    +        case _: TimestampMicros => (updater, ordinal, value) =>
    +          updater.setLong(ordinal, value.asInstanceOf[Long])
    +        case null => (updater, ordinal, value) =>
    --- End diff --
    
    ditto, add a default case.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to