GitHub user cclauss opened a pull request: https://github.com/apache/spark/pull/21960
[SPARK-23698] Remove unused definitions of long and unicode __intlike__ and __unicode__ were defined but not used in the existing code. __basestring()__was removed in Python 3 in favor of __str()__ because all str are Unicode. This simple change resolves an Undefined Name (__long__) and was originally suggested in #20838 which is currently mired in 50+ comments on unrelated modifications. @HyukjinKwon @holdenk ## What changes were proposed in this pull request? (Please fill in changes proposed in this fix) ## How was this patch tested? (Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests) (If this patch involves UI changes, please attach a screenshot; otherwise, remove this) Please review http://spark.apache.org/contributing.html before opening a pull request. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cclauss/spark patch-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/21960.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #21960 ---- commit 20d072e6e19114e485711b882ff5f48e48a884a1 Author: cclauss <cclauss@...> Date: 2018-08-02T05:24:03Z [SPARK-23698] Remove unused definitions of long and unicode __intlike__ and __unicode__ were defined but not used in the existing code. __basestring()__was removed in Python 3 in favor of __str()__ because all str are Unicode. This simple change resolves an Undefined Name (__long__) and was originally suggested in #20838 which is currently mired in 50+ comments on unrelated modifications. @HyukjinKwon @holdenk ---- --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org