GitHub user Satyajitv opened a pull request:

    https://github.com/apache/spark/pull/21961

    Spark 20597

    ## What changes were proposed in this pull request?
               
    (Please fill in changes proposed in this fix)
    Default topic first checks if TOPIC_OPTION_KEY is provided,
     if TOPIC_OPTION_KEY is provided then
            defaulttopic=TOPIC_OPTION_KEY
     else  TOPIC_OPTION_KEY is not provided then
             defaulttopic=PATH_OPTION_KEY
    ## How was this patch tested?
    Have tested the code in local, but would start writing tests once the 
approach is confirmed by @jaceklaskowski, as I am expecting change requests.
    
    PF more details on https://issues.apache.org/jira/browse/SPARK-20597
    
    Please review http://spark.apache.org/contributing.html before opening a 
pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Satyajitv/spark SPARK-20597

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/21961.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #21961
    
----
commit d4e1ed0c25121ad5bf24cfe137e2ee1bff430c94
Author: Satyajit Vegesna <satyajit@...>
Date:   2018-08-02T05:12:57Z

    SPARK-20597 KafkaSourceProvider falls back on path as synonym for topic

commit 381e66fa0bdd14b5754d8d81710021714e5fc031
Author: Satyajit Vegesna <satyajit@...>
Date:   2018-08-02T05:22:07Z

    Added parameters that were mistakenly taken out in previous commit

commit 6dc893a681721b51e61a9df099ae8f2c865c38c1
Author: Satyajit Vegesna <satyajit@...>
Date:   2018-08-02T05:24:13Z

    Added parameters that were mistakenly taken out in previous commit

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to