Github user mengxr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21898#discussion_r207444701
  
    --- Diff: core/src/main/scala/org/apache/spark/BarrierTaskContext.scala ---
    @@ -39,6 +44,17 @@ class BarrierTaskContext(
       extends TaskContextImpl(stageId, stageAttemptNumber, partitionId, 
taskAttemptId, attemptNumber,
           taskMemoryManager, localProperties, metricsSystem, taskMetrics) {
     
    +  private val barrierCoordinator: RpcEndpointRef = {
    +    val env = SparkEnv.get
    +    RpcUtils.makeDriverRef("barrierSync", env.conf, env.rpcEnv)
    --- End diff --
    
    It would be nice to define `"barrierSync"` as a constant.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to