Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/21986#discussion_r207954320
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala
---
@@ -123,7 +125,10 @@ trait HigherOrderFunction extends Expression {
}
}
-trait ArrayBasedHigherOrderFunction extends HigherOrderFunction with
ExpectsInputTypes {
+/**
+ * Trait for functions having as input one argument and one function.
+ */
+trait UnaryHigherOrderFunction extends HigherOrderFunction with
ExpectsInputTypes {
--- End diff --
We use the term `Unary` a lot and this is different from the other uses.
The name should convey a HigherOrderFunction that only uses a single (lambda)
function right? The only thing I can come up with is
`SingleHigherOrderFunction`. `Simple` would probably also be fine.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
