Github user rdblue commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21977#discussion_r208091782
  
    --- Diff: 
core/src/main/scala/org/apache/spark/api/python/PythonRunner.scala ---
    @@ -60,14 +61,26 @@ private[spark] object PythonEvalType {
      */
     private[spark] abstract class BasePythonRunner[IN, OUT](
         funcs: Seq[ChainedPythonFunctions],
    -    bufferSize: Int,
    -    reuseWorker: Boolean,
         evalType: Int,
    -    argOffsets: Array[Array[Int]])
    +    argOffsets: Array[Array[Int]],
    +    conf: SparkConf)
       extends Logging {
     
       require(funcs.length == argOffsets.length, "argOffsets should have the 
same length as funcs")
     
    +  private val bufferSize = conf.getInt("spark.buffer.size", 65536)
    +  private val reuseWorker = conf.getBoolean("spark.python.worker.reuse", 
true)
    +  private val memoryMb = {
    +    val allocation = conf.get(PYSPARK_EXECUTOR_MEMORY)
    +    if (reuseWorker) {
    --- End diff --
    
    No, I'm not sure where that is. Is it on the python side? If you can point 
me to it, I'll have a closer look.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to