Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22014#discussion_r208090085
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -471,6 +471,7 @@ class CodegenContext {
case NewFunctionSpec(functionName, None, None) => functionName
case NewFunctionSpec(functionName, Some(_),
Some(innerClassInstance)) =>
innerClassInstance + "." + functionName
+ case _ => null // nothing to do since addNewFunctionInteral() must
return one of them
--- End diff --
Shall we throw an `IllegalArgumentException`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
