Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21919#discussion_r208100226
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2.scala
 ---
    @@ -46,6 +46,9 @@ case class WriteToDataSourceV2(writer: DataSourceWriter, 
query: LogicalPlan) ext
      * The physical plan for writing data into data source v2.
      */
     case class WriteToDataSourceV2Exec(writer: DataSourceWriter, query: 
SparkPlan) extends SparkPlan {
    --- End diff --
    
    shall we create a new plan for writing micro-batch sink? If we are going to 
add more streaming related functionalities to this plan, we'd better separate 
the batch and streaming writing plans.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to