Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22030#discussion_r208439423
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala ---
    @@ -335,7 +337,7 @@ class RelationalGroupedDataset protected[sql](
        * @since 1.6.0
        */
       def pivot(pivotColumn: String, values: Seq[Any]): 
RelationalGroupedDataset = {
    -    pivot(Column(pivotColumn), values)
    +    pivot(Column(pivotColumn), values.map(lit))
    --- End diff --
    
    This is going to allow `pivot(String, Seq[Any])` also take `Column`. Did I 
misread the codes?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to