Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21859#discussion_r209407875
--- Diff: core/src/main/scala/org/apache/spark/Partitioner.scala ---
@@ -166,9 +169,17 @@ class RangePartitioner[K : Ordering : ClassTag, V](
// Assume the input partitions are roughly balanced and over-sample
a little bit.
val sampleSizePerPartition = math.ceil(3.0 * sampleSize /
rdd.partitions.length).toInt
val (numItems, sketched) = RangePartitioner.sketch(rdd.map(_._1),
sampleSizePerPartition)
+ val numSampled = sketched.map(_._3.length).sum
if (numItems == 0L) {
Array.empty
} else {
+ // already got the whole data
+ if (sampleCacheEnabled && numItems == numSampled) {
+ // get the sampled data
+ sampledArray = sketched.foldLeft(Array.empty[K])((total, sample)
=> {
--- End diff --
As you already know the size of `sampledArray`, maybe you can allocate it
at once in advance.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
