Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22070#discussion_r209416269
  
    --- Diff: 
sql/hive/src/test/resources/golden/udf_translate-2-f7aa38a33ca0df73b7a1e6b6da4b7fe8
 ---
    @@ -6,8 +6,8 @@ translate('abcdef', 'adc', '19') returns '1b9ef' replacing 
'a' with '1', 'd' wit
     
     translate('a b c d', ' ', '') return 'abcd' removing all spaces from the 
input string
     
    -If the same character is present multiple times in the input string, the 
first occurence of the character is the one that's considered for matching. 
However, it is not recommended to have the same character more than once in the 
from string since it's not required and adds to confusion.
    +If the same character is present multiple times in the input string, the 
first occurrence of the character is the one that's considered for matching. 
However, it is not recommended to have the same character more than once in the 
from string since it's not required and adds to confusion.
     
     For example,
     
    -translate('abcdef', 'ada', '192') returns '1bc9ef' replaces 'a' with '1' 
and 'd' with '9' ignoring the second occurence of 'a' in the from string 
mapping it to '2'
    +ththtranslate('abcdef', 'ada', '192') returns '1bc9ef' replaces 'a' with 
'1' and 'd' with '9' ignoring the second occurrence of 'a' in the from string 
mapping it to '2'
    --- End diff --
    
    `ththtranslate` is it correct .. ?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to