Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21561#discussion_r210468107
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/BisectingKMeans.scala ---
@@ -246,6 +245,16 @@ class BisectingKMeans private (
new BisectingKMeansModel(root, this.distanceMeasure)
}
+ /**
+ * Runs the bisecting k-means algorithm.
+ * @param input RDD of vectors
+ * @return model for the bisecting kmeans
+ */
+ @Since("1.6.0")
--- End diff --
You couldn't call `BisectingKMeans.run(...)` before this, right? it wasn't
in a superclass or anything. In that sense I think this method needs to be
marked as new as of 2.4.0, right?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
