Github user maropu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22154#discussion_r211435227
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/CodeGeneratorWithInterpretedFallback.scala
 ---
    @@ -63,7 +49,10 @@ abstract class CodeGeneratorWithInterpretedFallback[IN, 
OUT] {
             try {
               createCodeGeneratedObject(in)
             } catch {
    -          case CodegenError(_) => createInterpretedObject(in)
    +          case _: Exception =>
    +            // We should have already see error message in `CodeGenerator`
    +            logError("Expr codegen disabled and falls back to the 
interpreter mode")
    --- End diff --
    
    ok


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to