Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/22154#discussion_r211487231
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CodeGeneratorWithInterpretedFallbackSuite.scala
---
@@ -40,4 +55,13 @@ class CodeGeneratorWithInterpretedFallbackSuite extends
SparkFunSuite with PlanT
assert(obj.isInstanceOf[InterpretedUnsafeProjection])
}
}
+
+ test("fallback to the interpreter mode") {
+ val input = Seq(IntegerType).zipWithIndex.map(x =>
BoundReference(x._2, x._1, true))
--- End diff --
I'd also like to suggest changing the other test cases in this suite to do
something like `Seq(IntegerType).zipWithIndex.map { case (tpe, ordinal) =>
BoundReference(ordinal, tpe, true) }` to get rid of the `_2`, `_1`s. This is
also optional. WDYT @maropu @viirya ?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
