Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20637#discussion_r211812298
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
---
@@ -110,7 +116,7 @@ object GenerateUnsafeProjection extends
CodeGenerator[Seq[Expression], UnsafePro
}
val writeField = writeElement(ctx, input.value, index.toString,
dt, rowWriter)
- if (input.isNull == FalseLiteral) {
+ if (input.isNull == FalseLiteral || !nullable) {
--- End diff --
`input.isNull == FalseLiteral || ` is not needed?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
