Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/21320#discussion_r212194825 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRowConverter.scala --- @@ -202,11 +204,15 @@ private[parquet] class ParquetRowConverter( override def start(): Unit = { var i = 0 - while (i < currentRow.numFields) { + while (i < fieldConverters.length) { fieldConverters(i).updater.start() currentRow.setNullAt(i) i += 1 } + while (i < currentRow.numFields) { --- End diff -- @mallman It sounds like the changes in this file are not needed. Could you help me point out which test cases will fail?
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org