Github user maropu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22227#discussion_r213154483
  
    --- Diff: sql/core/src/test/resources/sql-tests/inputs/string-functions.sql 
---
    @@ -5,6 +5,10 @@ select format_string();
     -- A pipe operator for string concatenation
     select 'a' || 'b' || 'c';
     
    +-- split function
    +select split('aa1cc2ee', '[1-9]+', 2);
    +select split('aa1cc2ee', '[1-9]+');
    +
    --- End diff --
    
    Can you move these tests to the end of this file in order to decrease 
unnecessary changes in the golden file.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to