Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21912#discussion_r213539798
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
 ---
    @@ -1490,6 +1423,63 @@ object CodeGenerator extends Logging {
         }
       }
     
    +  /**
    +   * Generates code creating a [[UnsafeArrayData]] or [[GenericArrayData]] 
based on
    +   * given parameters.
    +   *
    +   * @param arrayName name of the array to create
    +   * @param elementType data type of the elements in source array
    +   * @param numElements code representing the number of elements the array 
should contain
    +   * @param additionalErrorMessage string to include in the error message
    +   * @param elementSize optional value which shows the size of an element 
of the allocated
    --- End diff --
    
    it's better to give an example when we will set it.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to