Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22316#discussion_r214566083
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala ---
    @@ -406,6 +407,14 @@ class RelationalGroupedDataset protected[sql](
        *   df.groupBy($"year").pivot($"course", Seq("dotNET", 
"Java")).sum($"earnings")
        * }}}
        *
    +   * For pivoting by multiple columns, use the `struct` function to 
combine the columns and values:
    --- End diff --
    
    Since the documentation states it's an overloaded version of ``` the 
`pivot` method with `pivotColumn` of the `String` type. ```, shall we move this 
contents to that method?
    
    Also, I would document this, for instance, 
    
    From Spark 2.4.0, values can be literal columns, for instance, `struct`. 
For pivoting by multiple columns, use the `struct` function to combine the 
columns and values.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to