Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22318#discussion_r214601491 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -895,6 +897,13 @@ class Analyzer( case _ => e.mapChildren(resolve(_, q)) } + private def rewriteJoinCondition( + e: Expression, + attributeRewrites: AttributeMap[Attribute]): Expression = e match { + case a: Attribute => attributeRewrites.getOrElse(a, a) + case _ => e.mapChildren(rewriteJoinCondition(_, attributeRewrites)) --- End diff -- nit: may be more clear to do: ``` case other => e.mapChildren(rewriteJoinCondition(other, attributeRewrites)) ```
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org