Github user jaceklaskowski commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22320#discussion_r214751023
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/test/DataFrameReaderWriterSuite.scala
 ---
    @@ -805,6 +805,80 @@ class DataFrameReaderWriterSuite extends QueryTest 
with SharedSQLContext with Be
         }
       }
     
    +  test("Insert overwrite table command should output correct schema: 
basic") {
    +    withTable("tbl", "tbl2") {
    +      withView("view1") {
    +        val df = spark.range(10).toDF("id")
    +        df.write.format("parquet").saveAsTable("tbl")
    +        spark.sql("CREATE VIEW view1 AS SELECT id FROM tbl")
    +        spark.sql("CREATE TABLE tbl2(ID long) USING parquet")
    +        spark.sql("INSERT OVERWRITE TABLE tbl2 SELECT ID FROM view1")
    +        val identifier = TableIdentifier("tbl2", Some("default"))
    --- End diff --
    
    `default` is the default database name, isn't it? I'd remove it from the 
test or use `spark.catalog.currentDatabase`.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to