Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22313#discussion_r214778262
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcFilterSuite.scala
 ---
    @@ -383,4 +386,13 @@ class OrcFilterSuite extends OrcTest with 
SharedSQLContext {
           )).get.toString
         }
       }
    +
    +  test("SPARK-25306 createFilter should not hang") {
    +    import org.apache.spark.sql.sources._
    +    val schema = new StructType(Array(StructField("a", IntegerType, 
nullable = true)))
    +    val filters = (1 to 2000).map(LessThan("a", _)).toArray[Filter]
    +    failAfter(2 seconds) {
    +      OrcFilters.createFilter(schema, filters)
    --- End diff --
    
    I'll choose (2), @cloud-fan .


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to