Github user jaceklaskowski commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22328#discussion_r215037968
  
    --- Diff: 
mllib/src/test/scala/org/apache/spark/ml/source/image/ImageFileFormatSuite.scala
 ---
    @@ -0,0 +1,119 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.ml.source.image
    +
    +import java.nio.file.Paths
    +
    +import org.apache.spark.SparkFunSuite
    +import org.apache.spark.ml.image.ImageSchema._
    +import org.apache.spark.mllib.util.MLlibTestSparkContext
    +import org.apache.spark.sql.Row
    +import org.apache.spark.sql.functions.{col, substring_index}
    +
    +class ImageFileFormatSuite extends SparkFunSuite with 
MLlibTestSparkContext {
    +
    +  // Single column of images named "image"
    +  private lazy val imagePath = "../data/mllib/images/imagesWithPartitions"
    +
    +  test("image datasource count test") {
    +    val df1 = spark.read.format("image").load(imagePath)
    +    assert(df1.count === 9)
    +
    +    val df2 = spark.read.format("image").option("dropImageFailures", 
"true").load(imagePath)
    --- End diff --
    
    `true` as a boolean value, please.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to