Github user mengxr commented on the issue:

    https://github.com/apache/spark/pull/22328
  
    That doesn't work for Java, if I remember the issue correctly.
    
    On Tue, Sep 4, 2018, 10:31 PM Wenchen Fan <notificati...@github.com> wrote:
    
    > *@cloud-fan* commented on this pull request.
    > ------------------------------
    >
    > In
    > 
mllib/src/main/scala/org/apache/spark/ml/source/image/ImageDataSource.scala
    > <https://github.com/apache/spark/pull/22328#discussion_r215140040>:
    >
    > > + *
    > + *   // Java
    > + *   Dataset<Row> df = spark.read().format("image")
    > + *     .option("dropImageFailures", "true")
    > + *     .load("data/mllib/images/imagesWithPartitions");
    > + * }}}
    > + *
    > + * IMAGE data source supports the following options:
    > + *  - "dropImageFailures": Whether to drop the files that are not valid 
images from the result.
    > + *
    > + * @note This IMAGE data source does not support "write".
    > + *
    > + * @note This class is public for documentation purpose. Please don't 
use this class directly.
    > + * Rather, use the data source API as illustrated above.
    > + */
    > +class ImageDataSource private() {}
    >
    > Is this a convention? AFAIK in the scala world we usually put document in
    > package object.
    >
    > —
    > You are receiving this because you were mentioned.
    > Reply to this email directly, view it on GitHub
    > <https://github.com/apache/spark/pull/22328#discussion_r215140040>, or 
mute
    > the thread
    > 
<https://github.com/notifications/unsubscribe-auth/AAyozMfwWO72FJuY89Yvq1Yl3L-oAOW6ks5uX2GtgaJpZM4WYrQ2>
    > .
    >
    -- 
    
    Xiangrui Meng
    
    Software Engineer
    
    Databricks Inc. [image: http://databricks.com] <http://databricks.com/>



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to