Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22319#discussion_r215142933
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/expressions/UserDefinedFunction.scala
---
@@ -129,3 +138,17 @@ case class UserDefinedFunction protected[sql] (
}
}
}
+
+// We have to use a name different than `UserDefinedFunction` here, to
avoid breaking the binary
+// compatibility of the auto-generate UserDefinedFunction object.
+private[sql] object SparkUserDefinedFunction {
--- End diff --
Oh, so we're working around by new object here. SGTM. I assumed mutable
status and copy stuff but trivial or not an issue.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
