Github user mccheah commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22323#discussion_r215456006
  
    --- Diff: 
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/LocalDirsFeatureStep.scala
 ---
    @@ -22,6 +22,7 @@ import java.util.UUID
     import io.fabric8.kubernetes.api.model.{ContainerBuilder, HasMetadata, 
PodBuilder, VolumeBuilder, VolumeMountBuilder}
     
     import org.apache.spark.deploy.k8s.{KubernetesConf, 
KubernetesDriverSpecificConf, KubernetesRoleSpecificConf, SparkPod}
    +import org.apache.spark.deploy.k8s.Config._
    --- End diff --
    
    Actually I think wildcard for configuration fields is probably ok. But we 
haven't been consistent.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to