Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22270#discussion_r215485269
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala ---
@@ -85,12 +85,12 @@ class DataFrameFunctionsSuite extends QueryTest with
SharedSQLContext {
}
val df5 = Seq((Seq("a", null), Seq(1, 2))).toDF("k", "v")
- intercept[RuntimeException] {
+ intercept[Exception] {
--- End diff --
@HyukjinKwon We get a SparkException here which in turn wraps a
RuntimeException. When we have ConvertToLocalRelation active, we get a
RuntimeException from driver. But when we disable it, the error is raised from
the executor with a SparkException as the top level exception. Thats the reason
i changed it to intercept `Exception` so that this test can run both when the
rule is active vs when its not.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
