Github user peter-toth commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22318#discussion_r215499599
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/AttributeMap.scala
 ---
    @@ -23,12 +23,14 @@ package org.apache.spark.sql.catalyst.expressions
      * of the name, or the expected nullability).
      */
     object AttributeMap {
    +  val empty = new AttributeMap(Map.empty)
    --- End diff --
    
    @gatorsmile this was the initial version. then came the idea of @mgaido91 
and @maropu to use val (instead of def) either here or in ResolveReferences to 
spare some empty() calls


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to