Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/22326#discussion_r215877417
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/FilterPushdownSuite.scala
---
@@ -1153,12 +1154,35 @@ class FilterPushdownSuite extends PlanTest {
"x.a".attr === Rand(10) && "y.b".attr === 5))
val correctAnswer =
x.where("x.a".attr === 5).join(y.where("y.a".attr === 5 &&
"y.b".attr === 5),
- condition = Some("x.a".attr === Rand(10)))
+ joinType = Cross).where("x.a".attr === Rand(10))
// CheckAnalysis will ensure nondeterministic expressions not appear
in join condition.
// TODO support nondeterministic expressions in join condition.
- comparePlans(Optimize.execute(originalQuery.analyze),
correctAnswer.analyze,
- checkAnalysis = false)
+ withSQLConf(SQLConf.CROSS_JOINS_ENABLED.key -> "true") {
+ comparePlans(Optimize.execute(originalQuery.analyze),
correctAnswer.analyze,
+ checkAnalysis = false)
+ }
+ }
+
+ test("join condition pushdown: deterministic and non-deterministic in
left semi join") {
--- End diff --
I didn't add SPARK-25314 cause it maybe a supplement for test("join
condition pushdown: deterministic and non-deterministic").
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
