Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/21618#discussion_r216133261
--- Diff:
core/src/test/scala/org/apache/spark/deploy/SparkHadoopUtilSuite.scala ---
@@ -77,6 +80,51 @@ class SparkHadoopUtilSuite extends SparkFunSuite with
Matchers {
})
}
+ test("test expanding glob path") {
--- End diff --
```
IIUC, the new feature is disabled as default since
spark.sql.sources.parallelGetGlobbedPath.numThreads is 0.
```
Yes that's right.
```
I am afraid these test causes are executed only with disabling the new
feature.
```
These mainly test the correctness of `sparkHadoopUtil.expandGlobPath`,
maybe it's necessary to keep.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
