Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21649#discussion_r216185288 --- Diff: R/pkg/R/DataFrame.R --- @@ -3905,6 +3905,16 @@ setMethod("rollup", groupedData(sgd) }) +isTypeAllowedForSqlHint <- function(x) { --- End diff -- This is only used once BTW. Shall we just put this into the inside of `hint`?
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org