GitHub user mallman opened a pull request:
https://github.com/apache/spark/pull/22394
[SPARK-25406][SQL] For ParquetSchemaPruningSuite.scala, move calls to
`withSQLConf` inside calls to `test`
(Link to Jira: https://issues.apache.org/jira/browse/SPARK-25406)
## What changes were proposed in this pull request?
The current use of `withSQLConf` in `ParquetSchemaPruningSuite.scala` is
incorrect. The desired configuration settings are not being set when running
the test cases.
This PR fixes that defective usage and addresses the test failures that
were previously masked by that defect.
## How was this patch tested?
I added code to relevant test cases to print the expected SQL configuration
settings and found that the settings were not being set as expected. When I
changed the order of calls to `test` and `withSQLConf` I found that the
configuration settings were being set as expected.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/VideoAmp/spark-public
spark-25406-fix_broken_schema_pruning_tests
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22394.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22394
----
commit 8cca76b7ec31c1c0cff1bd5b6772b43b49c30147
Author: Michael Allman <msa@...>
Date: 2018-09-11T15:10:08Z
For ParquetSchemaPruningSuite.scala, move calls to `withSQLConf` inside
calls to `test`
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
